Add aggregator CLI commands for configuration parameters by turmelclem · Pull Request #3438 · IntersectMBO/mithril

turmelclem · 2026-07-27T15:36:00Z

Content

aggregator cli :

export command
- look for markers on chain and export then into JSON format (if it exists, otherwise it export a default configuration)
import command generating datum file from a JSON file
- verifying user JSON file consistency (non zero values, configurations and enabled signed entity type consistency)
- verifying configuration to import against configuration on chain TODO
- checking datum that not exceed 10kb (since a full cardano transaction is 16kb) TODO
- writing a JSON HEX datum file at given path

protocol-config :

a adapter trait that is used by aggregagtor cli to retrieve information about protocol configuration markers
- with the intelligence to retrieve the configuration of the nearest known epoch
cbor encoding/decoding of marker configuration

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- All check jobs of the CI have succeeded
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested
Documentation
- Update README file (if relevant)
- Update documentation website (if relevant)
- Add dev blog post (if relevant)
- Add ADR blog post or Dev ADR entry (if relevant)
- No new TODOs introduced

Issue(s)

this PR closes #3392

github-advanced-security

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

github-actions · 2026-07-27T15:51:20Z

Test Results

5 files ± 0 209 suites ±0 54m 7s ⏱️ - 12m 19s
3 369 tests + 33 3 369 ✅ + 33 0 💤 ±0 0 ❌ ±0
11 225 runs +119 11 225 ✅ +119 0 💤 ±0 0 ❌ ±0

Results for commit a134e72. ± Comparison against base commit cfb446a.

♻️ This comment has been updated with latest results.

Copilot

Pull request overview

This PR introduces new aggregator CLI commands to export/import protocol configuration markers, along with a new mithril-protocol-config reader interface/model and Cardano-chain message/payload encoding support to make protocol configuration markers portable and verifiable.

Changes:

Add protocol-configuration export-markers / import-markers CLI commands (JSON export + datum generation/import validation).
Add protocol-configuration “tools” and dependency injection wiring to read on-chain markers and generate signed datums.
Add mithril-protocol-config models/messages (CBOR encoding) + payload signing structure + test doubles.

Reviewed changes

Copilot reviewed 26 out of 27 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
mithril-stm/Cargo.toml	Switch `ciborium` to workspace dependency for consistent versioning.
mithril-common/src/entities/type_alias.rs	Add hex-encoded secret key type alias for protocol configuration markers.
mithril-common/src/crypto_helper/ed25519_alias.rs	Add ED25519 type aliases for protocol configuration markers signing/verifying.
mithril-common/Cargo.toml	Switch `ciborium` to workspace dependency.
mithril-aggregator/src/tools/protocol_configuration.rs	New tool: verify imported configs against chain window + build signed datum + datum size check.
mithril-aggregator/src/tools/mod.rs	Register/export `ProtocolConfigurationTools`.
mithril-aggregator/src/test/double/dummies.rs	Add `Dummy` impl for `HumanReadableProtocolConfiguration` for tests.
mithril-aggregator/src/dependency_injection/containers/protocol_configuration.rs	New DI container for protocol-configuration commands.
mithril-aggregator/src/dependency_injection/containers/mod.rs	Export the new protocol-configuration DI container.
mithril-aggregator/src/dependency_injection/builder/support/compatibility.rs	Add construction + getter for a `ProtocolConfigurationMarkersReader` (prod vs dummy).
mithril-aggregator/src/dependency_injection/builder/mod.rs	Add stored dependency + container creation method for protocol-configuration commands.
mithril-aggregator/src/configuration.rs	Add `ProtocolConfigurationReaderParameters` + `ConfigurationSource` accessor for reader params.
mithril-aggregator/src/commands/protocol_configuration_command.rs	Implement CLI subcommands, JSON IO, consistency checks, datum generation.
mithril-aggregator/src/commands/mod.rs	Wire new `ProtocolConfiguration` command into main CLI.
internal/mithril-protocol-config/src/test/double/mod.rs	Export new dummy markers reader from test doubles.
internal/mithril-protocol-config/src/test/double/dummy_markers_reader.rs	Add dummy `ProtocolConfigurationMarkersReader` for test environments.
internal/mithril-protocol-config/src/test/double/dummies.rs	Add dummies for protocol-configuration marker models/messages.
internal/mithril-protocol-config/src/model.rs	Add protocol configuration marker model + `ConfigurationComputerFromMarkers` helper with fallback lookup.
internal/mithril-protocol-config/src/lib.rs	Export `cardano_chain` module publicly.
internal/mithril-protocol-config/src/interface.rs	Add `ProtocolConfigurationMarkersReader` trait.
internal/mithril-protocol-config/src/cardano_chain/protocol_configuration_reader.rs	Add Cardano-chain reader type for markers (currently stubbed).
internal/mithril-protocol-config/src/cardano_chain/payload.rs	Add payload structs and signing helper for protocol configuration markers.
internal/mithril-protocol-config/src/cardano_chain/mod.rs	Add Cardano-chain module exports for message/payload/reader.
internal/mithril-protocol-config/src/cardano_chain/message.rs	Add CBOR message/codec for protocol configuration markers.
internal/mithril-protocol-config/Cargo.toml	Add dependencies needed for CBOR/hex/serde + chain reader integration.
Cargo.toml	Add workspace `ciborium` dependency.
Cargo.lock	Lockfile updates for new deps/crate wiring.

Suppressed comments (1)

mithril-aggregator/src/commands/protocol_configuration_command.rs:345

User-facing CLI output contains spelling/grammar issues ("Sucessfuly write"), which makes the command output look unpolished.

        println!(
            "Sucessfuly write Tx datum file at {}",
            self.target_path.to_string_lossy()
        );

…empty read impl for cardano chain adapter

…gurationReader

…s with fallback logic for ProtocolConfigurationReader

…mport and on chain configurations

protocol configutation markers

…ion consistency for protocol-configuration import command

…rification on protocol-configuration command

…ism, and rework protocol-configuration command parameters

…eader, and using dedicated struct for CBOR conversion

…olverFromMarkers

…MithrilNetworkConfiguration

jpraynaud

LGTM 👍

Alenar

LGTM

Alenar · 2026-08-05T16:02:52Z

you forgot to rename the file following the renaming of the structure 😅

turmelclem self-assigned this Jul 27, 2026

github-advanced-security AI found potential problems Jul 27, 2026

View reviewed changes

github-advanced-security AI found potential problems Jul 29, 2026

View reviewed changes

github-advanced-security AI found potential problems Jul 30, 2026

View reviewed changes

turmelclem force-pushed the ctl/3392-add-aggregator-CLI-command-for-configuration-parameters branch 3 times, most recently from ddfd41b to 10aa1ef Compare July 30, 2026 12:38

github-advanced-security AI found potential problems Jul 31, 2026

View reviewed changes

Comment thread mithril-aggregator/src/commands/protocol_configuration_command.rs Fixed

Comment thread mithril-aggregator/src/commands/protocol_configuration_command.rs Fixed

turmelclem marked this pull request as ready for review July 31, 2026 12:05

turmelclem requested review from Alenar, curiecrypt, damrobi, hjeljeli32 and jpraynaud as code owners July 31, 2026 12:05

turmelclem force-pushed the ctl/3392-add-aggregator-CLI-command-for-configuration-parameters branch 6 times, most recently from 2d65553 to ccb24d2 Compare July 31, 2026 13:10

jpraynaud requested a review from Copilot July 31, 2026 13:16

Copilot started reviewing on behalf of jpraynaud July 31, 2026 13:17 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

turmelclem force-pushed the ctl/3392-add-aggregator-CLI-command-for-configuration-parameters branch 4 times, most recently from aba2fbb to 0f67a96 Compare July 31, 2026 15:54

turmelclem temporarily deployed to testing-preview July 31, 2026 16:09 — with GitHub Actions Inactive

turmelclem added 5 commits August 5, 2026 15:54

feature(protocol-config): init protocol configuration builder, and a …

03af381

…empty read impl for cardano chain adapter

feature(aggregator): implement dependency injection for ProtocolConfi…

ea9a8fb

…gurationReader

feature(protocol-config): implement a ConfigurationComputerFromMarker…

ab0a1c7

…s with fallback logic for ProtocolConfigurationReader

feature(aggregator, common): implementing verification between user i…

0654986

…mport and on chain configurations

feature(protocol-config, aggregator): use ciborium encoding/decoding for

57fb6e5

protocol configutation markers

turmelclem force-pushed the ctl/3392-add-aggregator-CLI-command-for-configuration-parameters branch from c990269 to 50e2689 Compare August 5, 2026 13:55

turmelclem requested review from Alenar and jpraynaud August 5, 2026 13:55

github-advanced-security AI found potential problems Aug 5, 2026

View reviewed changes

Comment thread mithril-aggregator/src/commands/protocol_configuration_command.rs Fixed

turmelclem force-pushed the ctl/3392-add-aggregator-CLI-command-for-configuration-parameters branch from 50e2689 to c7a16da Compare August 5, 2026 14:02

github-advanced-security AI found potential problems Aug 5, 2026

View reviewed changes

turmelclem added 6 commits August 5, 2026 16:14

feature(common, aggregator): check protocol parameters and configurat…

18165d7

…ion consistency for protocol-configuration import command

feature(aggregator): wiring on chain verification and datum size veri…

2845a30

…rification on protocol-configuration command

feature(aggregator, protocol-config): cleanning builder adapter mecan…

65bc61b

…ism, and rework protocol-configuration command parameters

feature(protocol-config, aggregator): simplify PrototolConfigurationR…

b343558

…eader, and using dedicated struct for CBOR conversion

refactor: move ciborium to workspace dependencies

c13a4a7

feature(aggregator): implement export protocol configurations command

7182d4a

turmelclem force-pushed the ctl/3392-add-aggregator-CLI-command-for-configuration-parameters branch from c7a16da to 5792cc0 Compare August 5, 2026 14:24

jpraynaud reviewed Aug 5, 2026

View reviewed changes

Comment thread mithril-aggregator/src/commands/protocol_configuration_command.rs

turmelclem force-pushed the ctl/3392-add-aggregator-CLI-command-for-configuration-parameters branch from 5792cc0 to 97b316f Compare August 5, 2026 14:46

turmelclem added 4 commits August 5, 2026 16:51

feature(aggregagor): add a default option for the export markers command

7141c8e

refactor: rename ConfigurationComputerFromMarkers to ConfigurationRes…

4ca0494

…olverFromMarkers

refactor(protocol-config): remove unused Deserialize, Serialize from …

a4b4cb9

…MithrilNetworkConfiguration

refactor(aggregator) move HumanReadableProtocolConfiguration into tools

a134e72

turmelclem force-pushed the ctl/3392-add-aggregator-CLI-command-for-configuration-parameters branch from 97b316f to a134e72 Compare August 5, 2026 14:51

turmelclem temporarily deployed to testing-2-preview August 5, 2026 15:11 — with GitHub Actions Inactive

turmelclem temporarily deployed to testing-preview August 5, 2026 15:11 — with GitHub Actions Inactive

turmelclem requested a review from jpraynaud August 5, 2026 15:28

jpraynaud approved these changes Aug 5, 2026

View reviewed changes

Alenar approved these changes Aug 5, 2026

View reviewed changes

Uh oh!

Conversation

turmelclem commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Pre-submit checklist

Issue(s)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpraynaud left a comment

Choose a reason for hiding this comment

Uh oh!

Alenar left a comment

Choose a reason for hiding this comment

Uh oh!

Alenar Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

turmelclem commented Jul 27, 2026 •

edited

Loading

github-actions Bot commented Jul 27, 2026 •

edited

Loading